-
Notifications
You must be signed in to change notification settings - Fork 249
Use Separate Version for Build vs. Source #3751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A pull request to separate build and source versions by introducing a new devops variable and adjusting pipeline steps.
- Added a new variable ACN_DEVOPS_DIR to distinguish between source and build directories.
- Introduced a new "copy" job and updated template references to include the '@acn-devops' suffix.
- Updated cleanup and file-copying steps in the build pipeline configuration.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
.pipelines/run-pipeline.yaml | Added ACN_DEVOPS_DIR variable, new copy job, and updated template references to separate build vs. source artifacts |
.pipelines/build/ob-prepare.steps.yaml | Removed commented-out code blocks and updated cleanup and copy steps for development source artifacts |
Comments suppressed due to low confidence (2)
.pipelines/build/ob-prepare.steps.yaml:2
- [nitpick] Consider removing the commented-out code if it is no longer required to improve clarity and reduce clutter in the file.
steps:
.pipelines/run-pipeline.yaml:30
- [nitpick] The variable 'ob_outputDirectory' is assigned different directory paths in the 'copy' and 'env' jobs. Please confirm that this divergence is intentional and ensure that downstream steps correctly reference these separate directories.
ob_outputDirectory: $(Build.SourcesDirectory)/azure-container-networking
Reason for Change:
Issue Fixed:
Requirements:
Notes: