[Service Tags] ci: Backport service/virtual tag updates to release/v1.5 #3750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uster creation (#3277) * Create an outbound public ip for LB/Cilium cluster * create and attach public ip for cilium e2e cluster * Test cluster independent ip creation * Test outbound public ip creation * Test outbound public ip creation * Test outbound public ip creation with azcli creds * Test outbound public ip creation with azcli creds * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add managed identity to public ip/load balancer * Add managed identity to public ip/load balancer * Test wo managed identity * Test wo managed identity * Add Public ip to one cluster * Add public to all cluster creations * Add public ip * Fix spacing * Fix spacing * Add LB to win cni v1 cluster * Add LB to win cni v1 cluster * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * updated service tag to 'DelegatedNetworkControllerTest' * create public IP as target * add ipv6 public ips to dualstack * updated v6 ip * remove space * added public ip for nodesubnet-byocni-nokubeproxy-up resource * addressed comments on PR * parameterize ip v4 & v6 Co-authored-by: Evan Baker <[email protected]> Signed-off-by: Keerthana Routhu <[email protected]> * address comments * address PR comments * Update hack/aks/Makefile Co-authored-by: John Payne <[email protected]> Signed-off-by: Keerthana Routhu <[email protected]> * test * test * test --------- Signed-off-by: Keerthana Routhu <[email protected]> Co-authored-by: shubham-pathak-03 <[email protected]> Co-authored-by: Evan Baker <[email protected]> Co-authored-by: John Payne <[email protected]>
update to virtual tag
There was a problem hiding this comment.
Pull Request Overview
This PR backports SFI service and virtual tag updates to the release/v1.5 branch to address recent failures. The key changes are:
- Introduction of new variables for public IP tagging and prefixes.
- Addition of new targets (e.g., ip, ipv4, ipv6) and updating several cluster creation commands to use these variables.
- Updating load-balancer parameters in multiple cluster creation commands.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Keerthana Routhu <[email protected]>
jpayne3506
changed the title
jpayne3506
approved these changes
Jun 23, 2025
|
This needs to hit |
jpayne3506
added
release/1.5
rbtr
approved these changes
Jun 23, 2025
iirc this was merged to master before the 1.6 branch. @k-routhu can you confirm this? |
It was, but I updated the tags -- the changes that went in initially were service tags, but because of capacity and service tag team not wanting to give us more service tags in certain regions, we had to switch from service tags to virtual tags (unless service tags were absolutely needed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Backporting SFI service and virtual tags to release/v1.5 to address failures mentioned here