{Misc} Remove some Python 2.7 legacy code #30368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atombrella
requested review from
zhoxing-ms,
jsntcy,
wangzelin007,
yanzhudd,
evelyn-ys,
jiasli,
calvinhzy,
digimaun,
kairu-ms,
necusjz and
bebound
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage message put | cmd storage message put update parameter content: updated property type from custom_type to string |
||
| storage message update | cmd storage message update update parameter content: updated property type from custom_type to string |
microsoft-github-policy-service
bot
added
the
customer-reported
atombrella
changed the title
|
Misc |
atombrella
commented
Nov 23, 2024
...e/cli/command_modules/keyvault/vendored_sdks/azure_keyvault_securitydomain/_serialization.py
Outdated
Show resolved
Hide resolved
atombrella
force-pushed
the
feature/python_27_dead
branch
from
9b941c7 to
87330fe
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
atombrella
force-pushed
the
feature/python_27_dead
branch
from
913f3c3 to
bd45b9f
Compare
|
@wangzelin007 @jiasli I won't add more to this PR. To summarize better what this PR contains: I fixed some of the warnings from the pyupgrade section from ruff. https://docs.astral.sh/ruff/rules/open-alias/ Apart from that, I have grepped all over the code to remove ImportError for obvious Python 2 libraries; mostly that was This one can also be fixed, but I didn't do so. There are two matches: This one finds a few matches, but pylint doesn't complain since it was fixed. Maybe because those few instances are a bit special. |
|
@atombrella, first, thanks for the great work. Do you mind creating separate PRs for each change, such as the |
This was referenced Nov 29, 2024
@jiasli :) I've opened some PRs that should be more granular in terms of changes. I'll close this PR. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed a bit of Python 2.7 code that I found by searching for
ImportErrorandPython 2.7.There are still quite a fair pieces of Python 2.7 compatibility around.
sys.version_infois a good place to start.Note that I also saw a fair chunk of https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow in the code
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.