{Pylint} Fix unnecessary-dunder-call #30365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
7 tasks
|
Pylint |
atombrella
reviewed
Nov 15, 2024
| @@ -229,7 +229,7 @@ def test_load_cert_file(self): | |||
| try: | |||
| blob, thumbprint = load_cert_file(pfx_file, testpassword) | |||
| except CLIInternalError as e: | |||
| self.assertTrue(e.error_msg.error_msg.__contains__('Invalid password or PKCS12 data')) | |||
| self.assertTrue(e.error_msg.error_msg in 'Invalid password or PKCS12 data') | |||
atombrella
reviewed
Nov 15, 2024
| @@ -63,7 +63,7 @@ def _validate_deployment_name_with_template_specs(namespace): | |||
| namespace.template_spec = namespace.template_spec.strip("\"") | |||
| if not is_valid_resource_id(namespace.template_spec): | |||
| raise CLIError('--template-spec is not a valid resource ID.') | |||
| if namespace.template_spec.__contains__("versions") is False: | |||
| if (namespace.template_spec in "versions") is False: | |||
There was a problem hiding this comment.
I'll check all code later. Some codes are so werid...
There was a problem hiding this comment.
These variables are also reversed, it should be "versions" in namespace.template_spec.
Reported to astral-sh/ruff#14423
bebound
commented
Nov 26, 2024
| @@ -481,23 +481,23 @@ def test_botservice_create_should_raise_error_for_invalid_app_id_args(self, reso | |||
| self.cmd('az bot create -g {rg} -n {botname} --appid {numbers_id} --app-type MultiTenant') | |||
| raise AssertionError() | |||
| except CLIError as cli_error: | |||
| assert cli_error.__str__() == expected_error | |||
| assert (str(cli_error)) == expected_error | |||
There was a problem hiding this comment.
There are nnnecessary parentheses.
Reported to astral-sh/ruff#14597
bebound
commented
Nov 28, 2024
| @@ -316,7 +316,7 @@ def flush(): | |||
| save(get_config_dir(), _session.generate_payload()) | |||
|
|
|||
| # reset session fields, retaining correlation id and application | |||
| _session.__init__(correlation_id=_session.correlation_id, application=_session.application) | |||
| _session.__init__(correlation_id=_session.correlation_id, application=_session.application) # pylint: disable=unnecessary-dunder-call | |||
There was a problem hiding this comment.
It uses __init__ to reset fields, so weird.
There was a problem hiding this comment.
I don't know why the original author write in this way. Maybe we can try replace with
_session = TelemetrySession(correlation_id=_session.correlation_id, application=_session.application)
|
This function contains so many Python black magic, it seems it not used anymore. |
bebound
commented
Nov 28, 2024
| setattr(sys.modules[__name__], func_name, delete_func) | ||
| return func_name | ||
|
|
||
|
|
There was a problem hiding this comment.
Confirmed with necusjz that it can be removed.
PS: It's also removed in this file: https://github.com/Azure/azure-cli/blob/05b75056dc6cfa1b55bb45ea80cbe52d3eb9bb42/src/azure-cli/azure/cli/command_modules/network/_util.py
There was a problem hiding this comment.
I would suggest moving this change to a separate PR.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
bebound
requested review from
zhoxing-ms,
jsntcy,
yanzhudd,
kairu-ms,
wangzelin007,
necusjz and
jiasli
as code owners
jiasli
reviewed
Nov 29, 2024
jiasli
reviewed
Nov 29, 2024
src/azure-cli/azure/cli/command_modules/containerapp/tests/latest/utils.py
Outdated
Show resolved
Hide resolved
|
|
Co-authored-by: Jiashuo Li <[email protected]>
bebound
commented
Dec 2, 2024
wangzelin007
previously approved these changes
Dec 3, 2024
jiasli
approved these changes
Dec 11, 2024
kairu-ms
approved these changes
Dec 11, 2024
zhoxing-ms
approved these changes
Dec 11, 2024
calvinhzy
approved these changes
Dec 11, 2024
evelyn-ys
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this with
ruff check . --select PLC2801 --fix --preview --unsafe-fixesunnecessary-dunder-callwas disabled in #26685Ref:
https://pylint.readthedocs.io/en/stable/user_guide/messages/convention/unnecessary-dunder-call.html
https://docs.astral.sh/ruff/rules/unnecessary-dunder-call/