[AKS] az aks update: Add --ip-families to support updating cluster network settings GA
#30360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks update | cmd aks update added parameter ip_families |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd,
yonzhan and
FumingZhang
microsoft-github-policy-service
bot
added
Auto-Assign
camrynl
changed the title
FumingZhang
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Queued live test to validate the change.
- test_aks_update_dualstack
|
|
||
| @AllowLargeResponse() | ||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus2') | ||
| def test_aks_update_dualstack(self, resource_group, resource_group_location): |
There was a problem hiding this comment.
Please commit the corresponding recording file (find it from pipeline artifact if the live test passed).
|
@camrynl please resolve the conflicts |
camrynl
force-pushed
the
camrynl/updateipfamilies
branch
from
36958ce to
e2ee2f2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 30360 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
approved these changes
Nov 29, 2024
zhoxing-ms
approved these changes
Nov 29, 2024
zhoxing-ms
changed the title
az aks update: Add --ip-families to support updating cluster network settings GA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks update --ip-families ipv4,ipv6Description
Brings --ip-families usage to CLI GA
Testing Guide
History Notes
[AKS]
az aks update: Add--ip-familiesto support updating cluster networkThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.