[RDBMS] az postgres flexible-server replica: Remove stop-replication command support
#30323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
@evelyn-ys please trigger checks and review. |
|
/azp run |
evelyn-ys
changed the title
postgres flexible-server replica: Remove stop-replication command supportaz postgres flexible-server replica: Remove stop-replication command support
|
Azure Pipelines successfully started running 3 pipeline(s). |
evelyn-ys
reviewed
Nov 27, 2024
| @@ -238,7 +238,6 @@ def load_flexibleserver_command_table(self, _): | |||
| custom_command_type=flexible_servers_custom_postgres, | |||
| client_factory=cf_postgres_flexible_servers) as g: | |||
| g.custom_command('create', 'flexible_replica_create', supports_no_wait=True) | |||
| g.custom_command('stop-replication', 'flexible_replica_stop', confirmation=True, deprecate_info=g.deprecate(redirect='postgres flexible-server replica promote', hide=True)) | |||
There was a problem hiding this comment.
This is breaking change, can't be merged until next breaking change window
|
Need to wait for next breaking change window |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server replicaDescription
Dec 2023: “promote” was added to be used instead of “stop-replication”: Stop replication is the term used in single server. Was inherited to flex but needed to be updated to promote.
Jan 2024: was hidden and deprecation warning was set
Testing Guide
azdev test
History Notes
[RDBMS]
az postgres flexible-server replica: Remove stop-replication command support