[AKS] Add Etags in AKS CLI #30309
Merged
[AKS] Add Etags in AKS CLI #30309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InduSridhar
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @InduSridhar, |
❌AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yonzhan and
FumingZhang
microsoft-github-policy-service
bot
added
Auto-Assign
FumingZhang
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Queued live test to validate the change.
- test_aks_nodepool_create_scale_delete
- test_aks_upgrade_upgrade_settings
FumingZhang
reviewed
Nov 12, 2024
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
FumingZhang
reviewed
Nov 12, 2024
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
…aks_commands.py Co-authored-by: FumingZhang <[email protected]>
…aks_commands.py Co-authored-by: FumingZhang <[email protected]>
…aks_commands.py Co-authored-by: FumingZhang <[email protected]>
…aks_commands.py Co-authored-by: FumingZhang <[email protected]>
FumingZhang
reviewed
Nov 12, 2024
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
…aks_commands.py Co-authored-by: FumingZhang <[email protected]>
case test_aks_nodepool_create_scale_delete failed with following error
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Dec 16, 2024
| @@ -933,7 +939,7 @@ def aks_upgrade(cmd, | |||
| # null out the SP profile because otherwise validation complains | |||
| instance.service_principal_profile = None | |||
|
|
|||
| return sdk_no_wait(no_wait, client.begin_create_or_update, resource_group_name, name, instance) | |||
| return sdk_no_wait(no_wait, client.begin_create_or_update, resource_group_name, name, instance, if_match=if_match, if_none_match=if_none_match) | |||
There was a problem hiding this comment.
add workaround for the old cloud profile
| @@ -2641,7 +2658,7 @@ def aks_agentpool_delete(cmd, client, resource_group_name, cluster_name, | |||
| raise CLIError("Node pool {} doesnt exist, " | |||
| "use 'aks nodepool list' to get current node pool list".format(nodepool_name)) | |||
|
|
|||
| return sdk_no_wait(no_wait, client.begin_delete, resource_group_name, cluster_name, nodepool_name) | |||
| return sdk_no_wait(no_wait, client.begin_delete, resource_group_name, cluster_name, nodepool_name, if_match=if_match) | |||
There was a problem hiding this comment.
add workaround for the old cloud profile
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Dec 20, 2024
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_agentpool_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_agentpool_decorator.py
Outdated
Show resolved
Hide resolved
…agentpool_decorator.py Co-authored-by: FumingZhang <[email protected]>
…agentpool_decorator.py Co-authored-by: FumingZhang <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
please add the changelog to History Notes section with impacted command/parameter, i.e., |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
modified the milestones:
January 2025 (2025-01-14),
February 2025 (2025-02-11)
yanzhudd
approved these changes
Jan 15, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[AKS]
az aks create: Add parameters--if-matchand--if-none-matchto support etag functionality for concurrency[AKS]
az aks update: Add parameters--if-matchand--if-none-matchto support etag functionality for concurrency[AKS]
az aks delete: Add parameters--if-matchand--if-none-matchto support etag functionality for concurrencyThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.