-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] PREVIEW: Support managed identity on Azure Arc-enabled Linux server #30267
Draft
jiasli
wants to merge
1
commit into
Azure:dev
Choose a base branch
from
jiasli:arc
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
Hi @jiasli, |
Validation for Breaking Change Starting...
Thanks for your contribution! |
Support managed identity on Azure Arc-enabled Linux server |
microsoft-github-policy-service
bot
added
Account
az login/account
Core
CLI core infrastructure
labels
Nov 6, 2024
evelyn-ys
reviewed
Nov 7, 2024
Comment on lines
+223
to
225
if _on_azure_arc(): | ||
return self.login_with_managed_identity_azure_arc_windows( | ||
identity_id=identity_id, allow_no_subscriptions=allow_no_subscriptions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if _on_azure_arc(): | |
return self.login_with_managed_identity_azure_arc_windows( | |
identity_id=identity_id, allow_no_subscriptions=allow_no_subscriptions) | |
if _on_azure_arc(): | |
return self.login_with_managed_identity_azure_arc( | |
identity_id=identity_id, allow_no_subscriptions=allow_no_subscriptions) |
rayluo
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az login --identity
Description
az login --identity
for Azure Arc #16573This is only a temporary solution.
If Azure Arc is detected, Azure CLI uses MSAL for managed identity authentication. For other platforms, such as VM and App Service, the existing logic is preserved. These platforms' migration will be done in #25959.