[SignalR]: Remove the default empty string of location #29242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @bjqian, |
️✔️AzureCLI-BreakingChangeTest
|
|
SignalR |
zackliu
approved these changes
Jun 25, 2024
kairu-ms
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az signalr upstream updateDescription
From api-version
2023-03-01, Azure SignalR introduced the common types in its swagger.The
locationproperty becomes required thus the generated Python SDK starts to mark it non-optional. This is kind of a too strong restriction and we introduce the empty string as default value for update scenario. It turns out this might break Arm Policy mentioned in this issue.What's done in this PR
Revert the
locationtoNoneto clear it from the request property.Testing Guide
az signalr upstream update -n MySignalR -g MyResourceGroup --template url-template="http://host.com/{hub}/{event}/{category}" category-pattern="messages" event-pattern="broadcast" hub-pattern="chat"
History Notes
[SignalR] remove the empty location string when updating resource
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.