{Packaging} Use latest homebrew formula #27326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
jiasli and
wangzelin007
|
Packaging |
bebound
commented
Sep 6, 2023
| # include pip when creating venv, see https://github.com/Homebrew/brew/pull/15792 | ||
| # this can be removed after Homebrew merges our PR | ||
| text = re.sub('system_site_packages: false', 'system_site_packages: false, without_pip: false', text, 1) | ||
|
|
There was a problem hiding this comment.
This is introduced in #27186, remove it as latest formula contains this change.
jiasli
approved these changes
Sep 11, 2023
bebound
commented
Nov 3, 2023
| TEMPLATE_FILE_NAME = 'formula_template.txt' | ||
| CLI_VERSION = os.environ['CLI_VERSION'] | ||
| HOMEBREW_UPSTREAM_URL = os.environ['HOMEBREW_UPSTREAM_URL'] | ||
| HOMEBREW_FORMULAR_LATEST = "https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/a/azure-cli.rb" |
There was a problem hiding this comment.
Formula was moved to /a in Homebrew/homebrew-core#138921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert #27074.
PS: Homebrew/homebrew-core#138921 also moves formula into
a/subdirectory.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.