Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Supporting resource Predictions types in mdp commands #8282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ajaykn
Copy link
Contributor

@ajaykn ajaykn commented Nov 14, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Currently in api spec we have "ResourcePredictions" as object
https://github.com/Azure/azure-rest-api-specs/blob/8e02612fe780d63dee33707f5ea189fec32ee36f/specification/devopsinfrastructure/resource-manager/Microsoft.DevOpsInfrastructure/stable/2024-10-19/devopsinfrastructure.json#L1439-L1441

But CLI command is not working when passed resource predictions.
Expected format:
image

Error we are seeing:
image

So added support for these types to unblock our customers.

We will update the api spec in future iteration, and come back here to update with auto-generated code.

please let me know if any concerns.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Hi @ajaykn,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

azure-client-tools-bot-prd bot commented Nov 14, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @ajaykn,
Since the current milestone time is less than 7 days, this pr may not catch up with this release.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 14, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Nov 14, 2024

@ajaykn
Copy link
Contributor Author

ajaykn commented Nov 14, 2024

Hi @ajaykn, Since the current milestone time is less than 7 days, this pr may not catch up with this release.

This is a bug fix, can we please get this to current milestone 🙇

@ajaykn ajaykn changed the title Supporting resource Predictions types in mdp commands [Bugfix] Supporting resource Predictions types in mdp commands Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants