-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Supporting resource Predictions types in mdp commands #8282
base: main
Are you sure you want to change the base?
Conversation
Hi @ajaykn, |
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @ajaykn, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
This is a bug fix, can we please get this to current milestone 🙇 |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Currently in api spec we have "ResourcePredictions" as object
https://github.com/Azure/azure-rest-api-specs/blob/8e02612fe780d63dee33707f5ea189fec32ee36f/specification/devopsinfrastructure/resource-manager/Microsoft.DevOpsInfrastructure/stable/2024-10-19/devopsinfrastructure.json#L1439-L1441
But CLI command is not working when passed resource predictions.
Expected format:
Error we are seeing:
So added support for these types to unblock our customers.
We will update the api spec in future iteration, and come back here to update with auto-generated code.
please let me know if any concerns.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.