-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft - Do not merge] [Quantum] Azure CLI leverages paginated jobs #8197
Draft
warren-jones
wants to merge
19
commits into
Azure:main
Choose a base branch
from
warren-jones:25267-azure-cli-leverages-paginated-jobs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Draft - Do not merge] [Quantum] Azure CLI leverages paginated jobs #8197
warren-jones
wants to merge
19
commits into
Azure:main
from
warren-jones:25267-azure-cli-leverages-paginated-jobs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
quantum job list | cmd quantum job list added parameter created_after |
||
quantum job list | cmd quantum job list added parameter created_before |
||
quantum job list | cmd quantum job list added parameter job_name |
||
quantum job list | cmd quantum job list added parameter job_status |
||
quantum job list | cmd quantum job list added parameter job_type |
||
quantum job list | cmd quantum job list added parameter jobs_per_page |
||
quantum job list | cmd quantum job list added parameter order |
||
quantum job list | cmd quantum job list added parameter orderby |
||
quantum job list | cmd quantum job list added parameter provider_id |
||
quantum job list | cmd quantum job list added parameter skip |
||
quantum job list | cmd quantum job list added parameter target_id |
Hi @warren-jones, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
kairu-ms,
necusjz,
yonzhan and
wangzelin007
October 24, 2024 23:39
Release SuggestionsModule: quantum
Notes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Restore old version number before clicking "Ready for review"
CLI section copied from AQ Job Pagination Design.docx:
Client update required
The data-plane client files in vendored_sdks must be updated after the API spec is updated. See PR 19707
See How to generate the control-plane and data-plane clients.
New params for
az quantum job list
Locations of code changes
list
function in job.pywith self.argument_context('quantum job list')…
block in theload_arguments
function in _params.py, with corresponding…_type
statements at the top of that function, including help textTemporary edit of an AutoREST-generated file:
To remediate the following error:
TypeError: type object got multiple values for keyword argument 'base_url'
...I had to replace line 72 In the AutoREST-generated file vendored_sdks\azure_quantum_client.py:
_endpoint = "https://{region}.{serviceBaseUrl}"
with:
_endpoint = kwargs.pop("base_url", None)
TO DO: We need to either figure out how to change the API spec so an error-free line is generated there, or patch the CLI's data-plane client to replace this line.
Testing
TO DO:
Related command
az quantum job list
General Guidelines
This checklist is used to make sure that common guidelines for a pull request are followed.
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)