Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several issues in converter #5050

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Fix several issues in converter #5050

merged 3 commits into from
Jan 8, 2025

Conversation

pshao25
Copy link
Member

@pshao25 pshao25 commented Jan 6, 2025

  1. ResourceListResult should be only replaced in arm.
  2. Properties in TrackedResource/ProxyResource should not be in resource model.

@mikeharder mikeharder mentioned this pull request Jan 7, 2025
Closed
@pshao25 pshao25 merged commit bba1e8c into Azure:main Jan 8, 2025
10 checks passed
@pshao25 pshao25 deleted the issuesFix branch January 8, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@live1206 live1206 live1206 approved these changes

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pshao25 @live1206