Using camal case for node file naming so the package can install on linux #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please comment if you have any concerns.
There is no well agreed on file naming conventions for node.js. (Python has one at https://www.python.org/dev/peps/pep-0008/)
We crossed checked several resources and we set on just using camel case for 2 reasons
I list the resource we have read for references:
a. felixge/node-style-guide#30
b. https://github.com/joyent/node/tree/master/lib (see how the node.js team itself does)
Amar and I discussed whether we should use Pascal casing for file which export a single Class per point of "a" above. We are leaning to keep what we have for the reason of "2" above as it doesn't make too much difference.
Regardless, the main goal moving forward is to maintain the consistence