Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using camal case for node file naming so the package can install on linux #154

Merged
merged 1 commit into from
Jul 2, 2015

Conversation

yugangw-msft
Copy link
Contributor

Please comment if you have any concerns.
There is no well agreed on file naming conventions for node.js. (Python has one at https://www.python.org/dev/peps/pep-0008/)
We crossed checked several resources and we set on just using camel case for 2 reasons

  1. Good Readability
  2. Existing "node-sdk-for-node" uses this style, but just have not be consistent. Moving forward we will take efforts to get it be.

I list the resource we have read for references:
a. felixge/node-style-guide#30
b. https://github.com/joyent/node/tree/master/lib (see how the node.js team itself does)

Amar and I discussed whether we should use Pascal casing for file which export a single Class per point of "a" above. We are leaning to keep what we have for the reason of "2" above as it doesn't make too much difference.

Regardless, the main goal moving forward is to maintain the consistence

yugangw-msft added a commit that referenced this pull request Jul 2, 2015
Using camal case for node file naming so the package can install on linux
@yugangw-msft yugangw-msft merged commit c9581ac into Azure:dev Jul 2, 2015
@yugangw-msft yugangw-msft deleted the case branch July 13, 2015 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant