-
Notifications
You must be signed in to change notification settings - Fork 175
adopt the removal of stringify-with-ref
library change
#5348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ArcturusZhang
wants to merge
17
commits into
Azure:main
Choose a base branch
from
ArcturusZhang:adopt-remove-stringify-with-ref-new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
adopt the removal of stringify-with-ref
library change
#5348
ArcturusZhang
wants to merge
17
commits into
Azure:main
from
ArcturusZhang:adopt-remove-stringify-with-ref-new
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringify-with-ref
library changestringify-with-ref
library change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adopts the changes from microsoft/typespec#7455
Supersedes #5339
it turns out we have quite a few issues around the
convenientApi
being true or false.The test project
FirstTest-TypeSpec
has the global setting ofgenerate-convenient-methods: false
, therefore if operations do not have@convenientApi(true)
, they should not have convenient methods.But in fact, quite a few such operations have convenience methods which leads to issues because TCGC would take that information correct and models/enums related will not be included.
I think we would not bother to fix that since it only happens in DPG - which will soon be superseded by the new generator.
To make everything works correctly, I just refines the typespec files so that our expectation for convenient methods would align with TCGC's
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?