Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Subscription Input #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feature: Add Subscription Input #16

wants to merge 3 commits into from

Conversation

benydc
Copy link

@benydc benydc commented Dec 15, 2022

No description provided.

@benydc
Copy link
Author

benydc commented Dec 15, 2022

@benydc please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

Contributor License Agreement

@microsoft-github-policy-service agree [company=""]

@benydc
Copy link
Author

benydc commented Dec 15, 2022

@microsoft-github-policy-service agree

@darena-patrick
Copy link

@ams0 any chance we can approve/merge this?

Copy link
Contributor

@ams0 ams0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@benydc
Copy link
Author

benydc commented Jan 13, 2023

@johnazariah can we have this merged please?

@johnazariah
Copy link
Member

I'm sorry - I don't have write access to this repo! @ams0 - can you please merge it as you see fit?

@ams0
Copy link
Contributor

ams0 commented Jan 16, 2023

Unfortunately I left the Azure org and with that I believe my rights in this repo. Can you perhaps ping someone internally to adopt this repo? Thanks @johnazariah

@benydc
Copy link
Author

benydc commented Feb 1, 2023

@johnazariah Any news regarding this contribution merge?

@sgone01
Copy link

sgone01 commented Feb 8, 2024

Hi @benydc While working on GHA recently, I discovered this repository to be helpful. However, I discovered one problem: after logging in, az account set -s <subscription> should be called.

Example:
az login ...

#after login then set subscription
az account set -s <subscription>

I encountered this problem and the present code set subscription prior to being called.
ERROR: The subscription of <subscription-name-or-id> doesn't exist in cloud 'AzureCloud'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants