Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Hyper-V to start waagent service #3334

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Require Hyper-V to start waagent service #3334

wants to merge 1 commit into from

Conversation

vittyvk
Copy link
Contributor

@vittyvk vittyvk commented Mar 21, 2025

Description

WALinuxAgent is Azure specific and Azure runs on Hyper-V. Add

ConditionVirtualization=microsoft

to service files to avoid starting WALA in other environments. In particular, this avoids polluting the console when the
same image is used both for Azure and some other env (e.g. local QEMU).

PR information

  • [ X ] Ensure development PR is based on the develop branch.
  • [ X ] The title of the PR is clear and informative.
  • [ X ] There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • [ - ] If applicable, the PR references the bug/issue that it fixes in the description.
  • [ - ] New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@vittyvk
Require Hyper-V to start waagent service
50f792f 
WALinuxAgent is Azure specific and Azure runs on Hyper-V. Add

 ConditionVirtualization=microsoft

to service files to avoid starting WALA in other environments. In
particular, this avoids polluting the console when the same image is used
both for Azure and some other env (e.g. local QEMU).

Signed-off-by: Vitaly Kuznetsov <[email protected]>
@narrieta
Copy link
Member

@anhvoms - could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narrieta narrieta Awaiting requested review from narrieta narrieta is a code owner

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

@nagworld9 nagworld9 Awaiting requested review from nagworld9 nagworld9 is a code owner

@maddieford maddieford Awaiting requested review from maddieford maddieford is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@anhvoms anhvoms

Labels
provisioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vittyvk @narrieta @anhvoms