Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate in the pipeline that policy id is not equal to any built-in policies #469

Merged
merged 9 commits into from
Sep 4, 2024

Conversation

Joshua-Donovan
Copy link
Collaborator

#393

Updated Built-In Name / GUID validation check to use public resource that does not require us to maintain an authorization token like the Github APIs would require.

Also updated dependencies to the latest versions.

@Joshua-Donovan
Copy link
Collaborator Author

Previous recommendation from pull request #425 to use the csv export from azadvertizer would have required parsing the csv.

wouldn't it be possible to check the GUID against https://www.azadvertizer.net/azpolicyadvertizer-comma.csv for uniqueness. In this case we wouldn't need any permissions or access tokens. The csv file is updated daily against Azure (built-in), ALZ, AMBA and Community Policies.

I found it easier in bash to use jq to parse the json response from: https://www.azadvertizer.net/AzPolicyAdvertizerRuleThemAllData.json
instead of parsing the csv for this use case.

@aschabus aschabus merged commit da88a29 into Azure:main Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate in the pipeline that policy id is not equal to any built-in policies
2 participants