-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracle Data base documentation updates #9360
Oracle Data base documentation updates #9360
Conversation
Solutions/OracleDatabaseAudit/Data Connectors/Connector_OracleDatabaseAudit.json
Outdated
Show resolved
Hide resolved
Hi @v-muuppugund, Please add releasenotes reference in CreateUi file and update same in zip add well. Thanks! |
Solutions/OracleDatabaseAudit/Data/system_generated_metadata.json
Outdated
Show resolved
Hide resolved
As discussed, JFYI, as these changes are documented related, so didn't check in, now pushed it. |
Hi @v-muuppugund, please add releasenotes reference in CreateUI file - and update same in zip as well. |
Release notes are missing in the solution its self,I have added,will link it and its not there in the solutions packaged earlier. |
Updated the Release notes |
Fixed the issue in local by debugging the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking for the testParameters.json file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.