Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Data base documentation updates #9360

Merged
merged 16 commits into from
Dec 22, 2023

Conversation

v-muuppugund
Copy link
Contributor

@v-muuppugund v-muuppugund commented Nov 9, 2023

Required items, please complete

Change(s):

  • Oracle Data base documentation

Reason for Change(s):

Version Updated:

  • 3.0.0

Testing Completed:

image
image

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@v-muuppugund v-muuppugund marked this pull request as ready for review December 15, 2023 13:30
@v-muuppugund v-muuppugund requested review from a team as code owners December 15, 2023 13:30
@v-muuppugund v-muuppugund changed the title Draft updates Oracle Data base documentation updates Dec 15, 2023
@v-sudkharat
Copy link
Contributor

Hi @v-muuppugund, Please add releasenotes reference in CreateUi file and update same in zip add well. Thanks!

@v-muuppugund
Copy link
Contributor Author

v-muuppugund commented Dec 19, 2023

Hi @v-muuppugund, Please add releasenotes reference in CreateUi file and update same in zip add well. Thanks!

As discussed, JFYI, as these changes are documented related, so didn't check in, now pushed it.

@v-sudkharat
Copy link
Contributor

Hi @v-muuppugund, please add releasenotes reference in CreateUI file -
image

and update same in zip as well.

@v-sudkharat
Copy link
Contributor

v-sudkharat commented Dec 19, 2023

Solution contains the Analytic rule, Hunting query. Please check on createUi file -
image

image

Same check on MainTemplate as well.

Its an issue with Yaml files ,i didn't change it

@v-sudkharat
Copy link
Contributor

The below Highlighted file is inside the package folder, could you please check on that -
image

@v-muuppugund
Copy link
Contributor Author

v-muuppugund commented Dec 19, 2023

The below Highlighted file is inside the package folder, could you please check on that - image

This came from package its self
image

@v-muuppugund
Copy link
Contributor Author

v-muuppugund commented Dec 19, 2023

Solution contains the Analytic rule, Hunting query. Please check on createUi file - image

![image](https://private-user-images.githubusercontent.com/132428394/291654832-aa16359d-9f1f-486e-a3f0-31267e82a18d.png?

jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDMwMDQ2MzUsIm5iZiI6MTcwMzAwNDMzNSwicGF0aCI6Ii8xMzI0MjgzOTQvMjkxNjU0ODMyLWFhMTYzNTlkLTlmMWYtNDg2ZS1hM2YwLTMxMjY3ZTgyYTE4ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBSVdOSllBWDRDU1ZFSDUzQSUyRjIwMjMxMjE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDIzMTIxOVQxNjQ1MzVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04NmI1MDBhMmNlNjU3Yzc2YjI4MzUxZjVjNjFmNDI3MmI1YTBiYTFiYWUyMDg2MDMzMzQ1NmM2Y2RjNzY2YWZhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.cdIqkSSB5tCEYGpRdSHwcUK6aQ2eJ2O4V25zaW57yks)

Same check on MainTemplate as well.

I didn't change any analytic rule and packaged it, then its should be earlier issue.

from the Yaml its self its unable to desterilize ,it's an existing issue,will check it
image

Its already present in solution metadata
image

@v-muuppugund
Copy link
Contributor Author

v-muuppugund commented Dec 19, 2023

Hi @v-muuppugund, please add releasenotes reference in CreateUI file - image

and update same in zip as well.

Release notes are missing in the solution its self,I have added,will link it and its not there in the solutions packaged earlier.

@v-muuppugund
Copy link
Contributor Author

Hi @v-muuppugund, Please add releasenotes reference in CreateUi file and update same in zip add well. Thanks!

Updated the Release notes

@v-muuppugund
Copy link
Contributor Author

Solution contains the Analytic rule, Hunting query. Please check on createUi file - image
![image](https://private-user-images.githubusercontent.com/132428394/291654832-aa16359d-9f1f-486e-a3f0-31267e82a18d.png?

jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDMwMDQ2MzUsIm5iZiI6MTcwMzAwNDMzNSwicGF0aCI6Ii8xMzI0MjgzOTQvMjkxNjU0ODMyLWFhMTYzNTlkLTlmMWYtNDg2ZS1hM2YwLTMxMjY3ZTgyYTE4ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBSVdOSllBWDRDU1ZFSDUzQSUyRjIwMjMxMjE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDIzMTIxOVQxNjQ1MzVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04NmI1MDBhMmNlNjU3Yzc2YjI4MzUxZjVjNjFmNDI3MmI1YTBiYTFiYWUyMDg2MDMzMzQ1NmM2Y2RjNzY2YWZhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.cdIqkSSB5tCEYGpRdSHwcUK6aQ2eJ2O4V25zaW57yks)

Same check on MainTemplate as well.

I didn't change any analytic rule and packaged it, then its should be earlier issue.

from the Yaml its self its unable to desterilize ,it's an existing issue,will check it image

Its already present in solution metadata image

Fixed the issue in local by debugging the code

@v-muuppugund
Copy link
Contributor Author

The below Highlighted file is inside the package folder, could you please check on that - image

This came from package its self image

Removed the test parameters file

v-sudkharat
v-sudkharat previously approved these changes Dec 21, 2023
Copy link
Contributor

@v-sudkharat v-sudkharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking for the testParameters.json file

Copy link
Contributor

@v-sudkharat v-sudkharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@v-dvedak v-dvedak merged commit b9ca241 into master Dec 22, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants