Addition of new CCP data connector GCP VPC flow logs #11829
+482
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul0216
reviewed
Feb 20, 2025
| @@ -0,0 +1,36 @@ | |||
| # GCP VPC flow logs Data Connector Configuration Guide | |||
There was a problem hiding this comment.
Keep the F and L capital in 'flow logs'
| ### List of Resources required | ||
|
|
||
| * Topic | ||
| * Subscription for the topic, |
| ] | ||
| } | ||
|
|
||
| output "An_output_message"{ |
There was a problem hiding this comment.
Instead of generic "An_output_message" can we use something like 'Instruction' or 'Next_Step'?
| { | ||
| "publisherId": "azuresentinel", | ||
| "offerId": "azure-sentinel-solution-gcpvpcflowlogs-api", | ||
| "firstPublishDate": "2024-11-11", |
| @@ -0,0 +1,104 @@ | |||
| { | |||
| "name": "GCPVPCFlowLogsCCPDefinition", | |||
| "apiVersion": "2022-09-01-preview", | |||
There was a problem hiding this comment.
Can you once check if a stable api version is available?
| [ | ||
| { | ||
| "name": "GCPFlowDCR", | ||
| "apiVersion": "2021-09-01-preview", |
There was a problem hiding this comment.
can we verify if any stable version of API is available?
| { "name": "location", "type": "string" }, | ||
| { "name": "project_id", "type": "string" }, | ||
| { "name": "subnetwork_id", "type": "string" }, | ||
| { "name": "subnetwork_name", "type": "string" }, |
There was a problem hiding this comment.
- Can column name be in PascalCase as TimeGenerated is? Most of the table definition follows PascalCase style column name including existing GCP based functions.
- You need to check in dcr file also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: