Merge branch 'Azure:master' into ApigeeConnector

.github/workflows/content-validations.yaml

@@ -9,9 +9,17 @@ on:
 jobs:
     ContentValidations:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: File Content Validations

.github/workflows/data-connector-validations.yaml

@@ -9,9 +9,17 @@ on:
 jobs:
     DataConnectorValidations:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: Data Connector Validations

.github/workflows/detection-template-schema-validations.yaml

@@ -8,7 +8,7 @@ on:
     workflow_dispatch:
 jobs:
     DetectionTemplateSchemaValidation:
-      runs-on: ubuntu-latest
+      runs-on: ubuntu-22.04
       env:
         buildConfiguration: Release
         dotnetSdkVersion: 3.1.401

.github/workflows/detection-validations.yaml

@@ -9,9 +9,17 @@ on:
 jobs:
     DetectionsValidations:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: Id Change Validation

.github/workflows/documents-link-validation.yaml

@@ -9,9 +9,17 @@ on:
 jobs:
     DocumentsLinkValidation:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: Documents link locale validation

.github/workflows/json-syntax-validation.yaml

@@ -9,9 +9,17 @@ on:
 jobs:
     JsonFileValidation:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: Json File Syntax Validation

.github/workflows/kql-validations.yaml

@@ -8,7 +8,7 @@ on:
     workflow_dispatch:
 jobs:
     KqlValidations:
-      runs-on: ubuntu-latest
+      runs-on: ubuntu-22.04
       env:
         buildConfiguration: Release
         dotnetSdkVersion: 6.0.x

.github/workflows/logo-validation.yaml

@@ -9,9 +9,17 @@ on:
 jobs:
     logoValidator:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: Logo File Validation

.github/workflows/non-ascii-validations.yaml

@@ -9,7 +9,7 @@ on:
     workflow_dispatch:
 jobs:
     NonAsciiValidations:
-      runs-on: ubuntu-latest
+      runs-on: ubuntu-22.04
       env:
         buildConfiguration: Release
         dotnetSdkVersion: 3.1.401

.github/workflows/playbook-validations.yaml

@@ -9,9 +9,17 @@ on:
 jobs:
     PlaybooksValidations:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: Playbook Validations

.github/workflows/sample-data-validation.yaml

@@ -9,9 +9,17 @@ on:
 jobs:
     sampleDataValidator:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: Sample Data Validator

.github/workflows/solution-validations.yaml

@@ -9,9 +9,17 @@ on:
 jobs:
     SolutionValidations:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: Solution Validations

.github/workflows/workbook-metadata-validations.yaml

@@ -9,9 +9,17 @@ on:
 jobs:
     WorkbooksValidations:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: Workbooks Metadata Validations

.github/workflows/workbook-template-validations.yaml

@@ -9,9 +9,17 @@ on:
 jobs:
     WorkbooksTemplateValidations:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: Workbooks Template Validations

.github/workflows/yaml-syntax-validation.yaml

@@ -9,11 +9,19 @@ on:
 jobs:
     YamlFileValidation:
       runs-on: ubuntu-latest
+      env:
+        REPO_OWNER: ${{ github.event.pull_request.base.repo.owner.login }}
+        REPO_NAME: ${{ github.event.pull_request.base.repo.name }}
+        PRNUM: ${{ github.event.pull_request.number }}
+        GITHUBAPPID: ${{ secrets.APPLICATION_ID }}
+        GITHUBAPPINSTALLATIONID: ${{ secrets.APPLICATION_INSTALLATION_ID }}
+        GITHUBAPPPRIVATEKEY: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+        SYSTEM_PULLREQUEST_ISFORK: ${{ github.event.pull_request.head.repo.fork }}
       steps:
       - uses: actions/checkout@v4
-      - run: npm install -g [email protected].15;which npm;npm -v
+      - run: npm install -g [email protected].18;which npm;npm -v
       - name: npm install
         run: npm install
       - name: YAML File Syntax Validation
-        run: npm run tsc && node .script/yamlFileValidator.js
+        run: npm run tsc && node .script/yamlFileValidator.js 
 

.script/SolutionValidations/solutionValidator.ts

@@ -1,11 +1,11 @@
-import { runCheckOverChangedFiles } from "./../utils/changedFilesValidator";
-import * as logger from "./../utils/logger";
-import { ExitCode } from "./../utils/exitCode";
-import { IsValidSolutionDomainsVerticals } from "./validDomainsVerticals";
-import { IsValidSupportObject } from "./validSupportObject";
-import { IsValidBrandingContent } from "./validMSBranding";
-import { IsValidSolutionID } from "./validSolutionID";
-import { MainTemplateDomainVerticalValidationError, MainTemplateSupportObjectValidationError, InvalidFileContentError, InvalidSolutionIDValidationError } from "../utils/validationError";
+import { runCheckOverChangedFiles } from "./../utils/changedFilesValidator.js";
+import * as logger from "./../utils/logger.js";
+import { ExitCode } from "./../utils/exitCode.js";
+import { IsValidSolutionDomainsVerticals } from "./validDomainsVerticals.js";
+import { IsValidSupportObject } from "./validSupportObject.js";
+import { IsValidBrandingContent } from "./validMSBranding.js";
+import { IsValidSolutionID } from "./validSolutionID.js";
+import { MainTemplateDomainVerticalValidationError, MainTemplateSupportObjectValidationError, InvalidFileContentError, InvalidSolutionIDValidationError } from "../utils/validationError.js";
 
 
 

.script/SolutionValidations/validDomainsVerticals.ts

@@ -1,6 +1,6 @@
-import { MainTemplateDomainVerticalValidationError } from "./../utils/validationError";
-import * as logger from "./../utils/logger";
-import { ExitCode } from "../utils/exitCode";
+import { MainTemplateDomainVerticalValidationError } from "./../utils/validationError.js";
+import * as logger from "./../utils/logger.js";
+import { ExitCode } from "../utils/exitCode.js";
 import fs from "fs";
 
 // initialize arrays to store valid domains and verticals

.script/SolutionValidations/validMSBranding.ts

@@ -1,5 +1,5 @@
-import { InvalidFileContentError } from "./../utils/validationError";
-import { ExitCode } from "../utils/exitCode";
+import { InvalidFileContentError } from "./../utils/validationError.js";
+import { ExitCode } from "../utils/exitCode.js";
 import fs from "fs";
 
 type AttributeConfig = {

.script/SolutionValidations/validSolutionID.ts

@@ -1,5 +1,5 @@
-import { InvalidSolutionIDValidationError } from "./../utils/validationError";
-import { ExitCode } from "../utils/exitCode";
+import { InvalidSolutionIDValidationError } from "./../utils/validationError.js";
+import { ExitCode } from "../utils/exitCode.js";
 import fs from "fs";
 
 export function IsValidSolutionID(filePath: string): ExitCode {

.script/SolutionValidations/validSupportObject.ts

@@ -1,5 +1,5 @@
-import { MainTemplateSupportObjectValidationError } from "./../utils/validationError";
-import { ExitCode } from "../utils/exitCode";
+import { MainTemplateSupportObjectValidationError } from "./../utils/validationError.js";
+import { ExitCode } from "../utils/exitCode.js";
 import fs from "fs";
 
 // function to check if the solution has a valid support object

.script/contentValidator.ts

@@ -1,7 +1,7 @@
 import fs from "fs";
-import { runCheckOverChangedFiles } from "./utils/changedFilesValidator";
-import { ExitCode } from "./utils/exitCode";
-import * as logger from "./utils/logger";
+import { runCheckOverChangedFiles } from "./utils/changedFilesValidator.js";
+import { ExitCode } from "./utils/exitCode.js";
+import * as logger from "./utils/logger.js";
 
 export async function ValidateFileContent(filePath: string): Promise<ExitCode> 
 {

.script/dataConnectorValidator.ts

@@ -1,12 +1,12 @@
 import fs from "fs";
-import { runCheckOverChangedFiles } from "./utils/changedFilesValidator";
-import { ExitCode } from "./utils/exitCode";
-import { isValidSchema } from "./utils/jsonSchemaChecker";
-import { isValidId } from "./utils/dataConnectorCheckers/idChecker";
-import { isValidDataType } from "./utils/dataConnectorCheckers/dataTypeChecker";
-import { isValidPermissions } from "./utils/dataConnectorCheckers/permissionsChecker";
-import * as logger from "./utils/logger";
-import { ConnectorCategory } from "./utils/dataConnector";
+import { runCheckOverChangedFiles } from "./utils/changedFilesValidator.js";
+import { ExitCode } from "./utils/exitCode.js";
+import { isValidSchema } from "./utils/jsonSchemaChecker.js";
+import { isValidId } from "./utils/dataConnectorCheckers/idChecker.js";
+import { isValidDataType } from "./utils/dataConnectorCheckers/dataTypeChecker.js";
+import { isValidPermissions } from "./utils/dataConnectorCheckers/permissionsChecker.js";
+import * as logger from "./utils/logger.js";
+import { ConnectorCategory } from "./utils/dataConnector.js";
 
 export async function IsValidDataConnectorSchema(filePath: string): Promise<ExitCode> {
 

.script/documentsLinkValidator.ts

@@ -1,7 +1,7 @@
-import { runCheckOverChangedFiles } from "./utils/changedFilesValidator";
-import { ExitCode } from "./utils/exitCode";
+import { runCheckOverChangedFiles } from "./utils/changedFilesValidator.js";
+import { ExitCode } from "./utils/exitCode.js";
 import fs from "fs";
-import * as logger from "./utils/logger";
+import * as logger from "./utils/logger.js";
 
 export async function IsFileContainsLinkWithLocale(filePath: string): Promise<ExitCode> {
   const content = fs.readFileSync(filePath, "utf8");