Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ExpressRoute gateways recommendation #631

Merged
merged 4 commits into from
Jan 24, 2025
Merged

fix: ExpressRoute gateways recommendation #631

merged 4 commits into from
Jan 24, 2025

Conversation

tksh164
Copy link
Member

@tksh164 tksh164 commented Jan 23, 2025 •
edited
Loading

Overview/Summary

  • Change the YAML styling of the longDescription to consistency.
  • Remove a low relevant learn more link.
  • Remove the double line breaks at the end of the file.

Related Issues/Work Items

Breaking Changes

  • None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings January 23, 2025 06:11
@tksh164 tksh164 requested review from a team as code owners January 23, 2025 06:11
Copilot
Copilot AI reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

azure-resources/Network/expressRouteGateways/recommendations.yaml Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added the Bug 🐞 Something isn't working label Jan 23, 2025
ehaslett
ehaslett approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ejhenry
ejhenry approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejhenry ejhenry merged commit e0a10a9 into main Jan 24, 2025
14 checks passed
@tksh164 tksh164 deleted the fix/expressroutegateways branch January 25, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ejhenry ejhenry ejhenry approved these changes

@ehaslett ehaslett ehaslett approved these changes

Assignees
No one assigned
Labels
Bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tksh164 @ejhenry @ehaslett