Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: aisearch resiliency recommendations #603

Closed
wants to merge 0 commits into from
Closed

Conversation

ripadrao
Copy link
Contributor

@ripadrao ripadrao commented Jan 7, 2025

Overview/Summary

AI Search resiliency: Enable AZ support in AI Search by configuring multiple replicas to your search service
AI Search Resiliency: Enable Multi Region deployments for AI Search

Related Issues/Work Items

https://dev.azure.com/CSUSolEng/Accelerator%20-%20AI/_workitems/edit/38367
https://dev.azure.com/CSUSolEng/Accelerator%20-%20AI/_workitems/edit/38366

image image image image image image
  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings January 7, 2025 10:32
@ripadrao ripadrao requested a review from a team as a code owner January 7, 2025 10:32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

azure-resources/CognitiveServices/AIsearch/recommendations.yaml:11

  • The word 'potentialBenefits' is incorrectly placed within the description text and should be removed.
longDescription: | Availability zones are used when adding multiple replicas to your search service. Each replica is assigned to a different zone in the region. If there are more replicas than zones, they are distributed as evenly as possible across the available zones.  potentialBenefits: High Availability

azure-resources/CognitiveServices/AIsearch/kql/b376281d-bfec-4695-8f90-9a44544fdfa4.kql:7

  • The use of strcat is redundant when concatenating a single property. It should be replaced with the property itself.
| project recommendationId = "b376281d-bfec-4695-8f90-9a44544fdfa4", name, id, param1 = strcat(properties['replicaCount']) , param2 = strcat(location)
@Rajani-Janaki-Ram
Copy link

@ejhenry can you please review this?

Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ripadrao, thanks for your PR! AI Search should fall underneath Microsoft.Search/searchServices as that is the provider and resource type declaration in ARM. Please move the files to that path. Feel free to ping me if you have questions.

@oZakari oZakari added Enhancement 🆕 New feature or request Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Jan 9, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity label Jan 13, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity labels Jan 13, 2025
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ripadrao

@ejhenry ejhenry added the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Jan 15, 2025
auto-merge was automatically disabled January 15, 2025 10:25

Head branch was pushed to by a user without write access

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Jan 15, 2025
auto-merge was automatically disabled January 15, 2025 10:28

Head branch was pushed to by a user without write access

@ripadrao ripadrao requested a review from a team as a code owner January 15, 2025 10:28
auto-merge was automatically disabled January 15, 2025 10:30

Head branch was pushed to by a user without write access

auto-merge was automatically disabled January 15, 2025 10:30

Head branch was pushed to by a user without write access

@ejhenry ejhenry added Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author and removed Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team. labels Jan 16, 2025
auto-merge was automatically disabled January 16, 2025 09:02

Head branch was pushed to by a user without write access

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Jan 16, 2025
auto-merge was automatically disabled January 20, 2025 13:49

Head branch was pushed to by a user without write access

@ripadrao ripadrao closed this Jan 20, 2025
auto-merge was automatically disabled January 20, 2025 13:49

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants