-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: aisearch resiliency recommendations #603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
azure-resources/CognitiveServices/AIsearch/recommendations.yaml:11
- The word 'potentialBenefits' is incorrectly placed within the description text and should be removed.
longDescription: | Availability zones are used when adding multiple replicas to your search service. Each replica is assigned to a different zone in the region. If there are more replicas than zones, they are distributed as evenly as possible across the available zones. potentialBenefits: High Availability
azure-resources/CognitiveServices/AIsearch/kql/b376281d-bfec-4695-8f90-9a44544fdfa4.kql:7
- The use of
strcat
is redundant when concatenating a single property. It should be replaced with the property itself.
| project recommendationId = "b376281d-bfec-4695-8f90-9a44544fdfa4", name, id, param1 = strcat(properties['replicaCount']) , param2 = strcat(location)
@ejhenry can you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ripadrao, thanks for your PR! AI Search should fall underneath Microsoft.Search/searchServices as that is the provider and resource type declaration in ARM. Please move the files to that path. Feel free to ping me if you have questions.
azure-resources/CognitiveServices/AIsearch/recommendations.yaml
Outdated
Show resolved
Hide resolved
azure-resources/CognitiveServices/AIsearch/recommendations.yaml
Outdated
Show resolved
Hide resolved
azure-resources/CognitiveServices/AIsearch/recommendations.yaml
Outdated
Show resolved
Hide resolved
azure-resources/CognitiveServices/AIsearch/recommendations.yaml
Outdated
Show resolved
Hide resolved
azure-resources/CognitiveServices/AIsearch/recommendations.yaml
Outdated
Show resolved
Hide resolved
azure-resources/CognitiveServices/AIsearch/recommendations.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ripadrao
azure-resources/Search/searchServices/kql/dff62efe-c3a3-4621-98b3-c877c65cb195.kql
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
azure-resources/Search/searchServices/kql/dff62efe-c3a3-4621-98b3-c877c65cb195.kql
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Pull request was closed
Overview/Summary
AI Search resiliency: Enable AZ support in AI Search by configuring multiple replicas to your search service
AI Search Resiliency: Enable Multi Region deployments for AI Search
Related Issues/Work Items
https://dev.azure.com/CSUSolEng/Accelerator%20-%20AI/_workitems/edit/38367
https://dev.azure.com/CSUSolEng/Accelerator%20-%20AI/_workitems/edit/38366
main
branch