Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Added new APRL recommendations for App Insights for Machine learning #577

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

docs: Added new APRL recommendations for App Insights for Machine learning #577

wants to merge 10 commits into from
+44 −0

Conversation

sonmitt
Copy link
Contributor

@sonmitt sonmitt commented Dec 16, 2024 •
edited
Loading

Overview/Summary

Added new APRL recommendations for App Insights for Azure Machine learning as part of resiliency AI specialized workloads

Related Issues/Work Items

Fixes ADO Task AB#38373

Breaking Changes

  1. Added new recommendations in Insights/components
  2. Created and added new recommendations in Insights/dataCollectionEndpoints

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings December 16, 2024 13:15
@sonmitt sonmitt requested a review from a team as a code owner December 16, 2024 13:15
Copilot
Copilot AI reviewed Dec 16, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
@sonmitt
Copy link
Contributor Author

sonmitt commented Dec 16, 2024

@ejhenry, Please review the PR and provide approval.

@sonmitt
Copy link
Contributor Author

sonmitt commented Dec 16, 2024

@Azure/aprl-ai, tagging for review.

@sonmitt sonmitt requested a review from a team as a code owner December 16, 2024 13:49
ejhenry
ejhenry reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These recommendations should be located within the specialized workload section as they are targeting a specific use case of the service and cannot be validated with ARG.

@ejhenry ejhenry added Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Dec 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Dec 19, 2024
@sonmitt sonmitt force-pushed the AppInsights-APRL-38373 branch from 7ae5c21 to 92d6ac3 Compare December 19, 2024 06:20
@sonmitt
Copy link
Contributor Author

sonmitt commented Dec 19, 2024

@ejhenry, Thanks for clarification, the recommendations have been moved to specialized workload section with recommendationResourceType: Microsoft.Subscription/subscriptions

@oZakari oZakari requested a review from ejhenry December 20, 2024 04:07
oZakari
oZakari approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for the dataCollectionEndpoints I do see this is a valid resource type, so okay with leaving it since you are leaving it hidden.

@oZakari oZakari added the Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@ejhenry ejhenry ejhenry left review comments

@oZakari oZakari oZakari approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonmitt @oZakari @ejhenry