-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new VM recommendation for ZRS Disk #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @pinyuko! Just a couple items to address:
- Please ensure the ARG query output matches the column names in the contribution guide
- Please ensure the longDescription is 300 characters or less
- Please include only 1 learnMoreLink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview/Summary
Added a new VM recommendation and query for "Use ZRS Disks or Protect LRS Disks from Availability Zone Failure" (fa0cf4f5-0b21-47b7-89a9-ee936f193ce1) after discussion and verification with Disk PM Bea Vincent and Ryan Draper.
Related Issues/Work Items
Replace this with a list of related GitHub Issues and/or ADO Work Items (Internal Only)
AB#
succeeded with the ADO Work Item ID.This PR fixes/adds/changes/removes
Breaking Changes
N/A
As part of this pull request I have
main
branch