Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new VM recommendation for ZRS Disk #55

Merged
merged 10 commits into from
Apr 24, 2024
Merged

Conversation

pinyuko
Copy link
Contributor

@pinyuko pinyuko commented Apr 17, 2024

Overview/Summary

Added a new VM recommendation and query for "Use ZRS Disks or Protect LRS Disks from Availability Zone Failure" (fa0cf4f5-0b21-47b7-89a9-ee936f193ce1) after discussion and verification with Disk PM Bea Vincent and Ryan Draper.

Related Issues/Work Items

Replace this with a list of related GitHub Issues and/or ADO Work Items (Internal Only)

  • To associate a GitHub Issue, use a key word preceded with the GitHub issue number.
  • To associate an ADO Work Item, use the key word AB# succeeded with the ADO Work Item ID.

This PR fixes/adds/changes/removes

  1. Added a new VM recommendation for "Use ZRS Disks or Protect LRS Disks from Availability Zone Failure" (fa0cf4f5-0b21-47b7-89a9-ee936f193ce1)
  2. Added query for "Use ZRS Disks or Protect LRS Disks from Availability Zone Failure" (fa0cf4f5-0b21-47b7-89a9-ee936f193ce1)

Breaking Changes

N/A

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@pinyuko
Copy link
Contributor Author

pinyuko commented Apr 17, 2024

Screenshot of ARG query

image

@pinyuko pinyuko marked this pull request as ready for review April 17, 2024 01:07
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @pinyuko! Just a couple items to address:

  • Please ensure the ARG query output matches the column names in the contribution guide
  • Please ensure the longDescription is 300 characters or less
  • Please include only 1 learnMoreLink

@ejhenry ejhenry added Area: Resource Guidance 📝 Improvements or additions to documentation Area: Resource Graph Query(s) #️⃣ Related to ARG queries Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Apr 17, 2024
@pinyuko pinyuko requested a review from a team as a code owner April 18, 2024 21:36
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Apr 18, 2024
@pinyuko
Copy link
Contributor Author

pinyuko commented Apr 18, 2024

New screenshot for ARG
image

Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejhenry ejhenry requested a review from Dost2010 April 22, 2024 19:20
@ejhenry ejhenry added the Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team. label Apr 23, 2024
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari merged commit d909025 into Azure:main Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants