Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NATGW Recommendations Update PG Signoff changes #515

Merged
merged 7 commits into from
Nov 20, 2024
Merged

feat: NATGW Recommendations Update PG Signoff changes #515

merged 7 commits into from
Nov 20, 2024

Conversation

rozkurt
Copy link
Contributor

@rozkurt rozkurt commented Nov 10, 2024

Overview/Summary

This PR includes updates as part of PG signoff process. Anavi from PG team suggested to remove recommendation number 1 and 3 on this category.

Related Issues/Work Items

Fixes AB#37692
-->

Breaking Changes

  1. N/A

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@rozkurt rozkurt requested review from a team as code owners November 10, 2024 19:58
ehaslett
ehaslett previously approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with recommendations from Anavi. LGTM

@oZakari oZakari changed the title NATGW_Recommendations_Update_PG_Signoff feat: NATGW_Recommendations_Update_PG_Signoff Nov 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Enhancement 🆕 New feature or request label Nov 11, 2024
@ejhenry ejhenry added the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Nov 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity label Nov 19, 2024
rodrigosantosms
rodrigosantosms requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@rodrigosantosms rodrigosantosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work with @zach to drop the changes made to the PPT and other files. There should be only changes to the KQL and YAML files.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity label Nov 20, 2024
@oZakari oZakari removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Nov 20, 2024
@oZakari oZakari closed this Nov 20, 2024
@oZakari oZakari reopened this Nov 20, 2024
oZakari
oZakari previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ehaslett
ehaslett previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari changed the title feat: NATGW_Recommendations_Update_PG_Signoff feat: NATGW Recommendations Update PG Signoff Nov 20, 2024
@github-actions github-actions bot dismissed stale reviews from rodrigosantosms, ehaslett, and oZakari via 9457489 November 20, 2024 20:09
@oZakari oZakari closed this Nov 20, 2024
@oZakari oZakari reopened this Nov 20, 2024
@oZakari oZakari changed the title feat: NATGW Recommendations Update PG Signoff feat: NATGW Recommendations Update PG Signoff changes Nov 20, 2024
@oZakari oZakari merged commit aa7807f into Azure:main Nov 20, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhenry ejhenry ejhenry left review comments

@oZakari oZakari oZakari approved these changes

@rodrigosantosms rodrigosantosms rodrigosantosms left review comments

@ehaslett ehaslett ehaslett left review comments

Assignees
No one assigned
Labels
Enhancement 🆕 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rozkurt @rodrigosantosms @oZakari @ejhenry @ehaslett