Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added AZ recommendation for Cosmos DB #417

Merged
merged 6 commits into from
Sep 19, 2024
Merged

feat: Added AZ recommendation for Cosmos DB #417

merged 6 commits into from
Sep 19, 2024

Conversation

kovarikthomas
Copy link
Contributor

Overview/Summary

Related Issues/Work Items

Breaking Changes

  1. None

As part of this pull request I have

  1. Added AZ recommendation for Cosmos DB
image
  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@kovarikthomas kovarikthomas requested a review from a team as a code owner September 19, 2024 05:54
@kovarikthomas kovarikthomas changed the title Added AZ recommendation for Cosmos DB feat: Added AZ recommendation for Cosmos DB Sep 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Enhancement 🆕 New feature or request label Sep 19, 2024
ejhenry
ejhenry approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kovarikthomas! LGTM 👍

@rodrigosantosms rodrigosantosms self-requested a review September 19, 2024 20:19
@oZakari oZakari merged commit f096646 into Azure:main Sep 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhenry ejhenry ejhenry approved these changes

@rodrigosantosms rodrigosantosms rodrigosantosms approved these changes

Assignees
No one assigned
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Area: Resource Guidance 📝 Improvements or additions to documentation Enhancement 🆕 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kovarikthomas @rodrigosantosms @ejhenry @oZakari