bug: fix order of spinkube params and url #5896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bravebeaver
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
timmy-wright,
zachary-bailey and
smith1511
as code owners
AlisonB319
reviewed
Feb 21, 2025
AlisonB319
approved these changes
Feb 21, 2025
bravebeaver
force-pushed
the
beileih/fixSpinkubeUrl
branch
from
52b4510 to
33d0f57
Compare
djsly
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
it seems that the order of param to call spinkube is wrong.. fix it
What this PR does / why we need it:
clean up use of "local" not in a function, according to linter.
fix misspelt variable name and then realise the params are out of order.
Requirements:
tested with existing e2e
Special notes for your reviewer:
Release note: