Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: log file sizes that are cached on the windows VHD #5884

Merged
merged 2 commits into from
Feb 20, 2025
Merged

chore: log file sizes that are cached on the windows VHD #5884

merged 2 commits into from
Feb 20, 2025

Conversation

timmy-wright
Copy link
Contributor

What type of PR is this?

/kind chore

What this PR does / why we need it:

  • logs file sizes for downloaded binaries
  • enables pipeline cleanup

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

smith1511
smith1511 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@smith1511 smith1511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timmy-wright timmy-wright enabled auto-merge (squash) February 19, 2025 23:22
@timmy-wright timmy-wright merged commit 93d49e8 into master Feb 20, 2025
23 checks passed
@timmy-wright timmy-wright deleted the timmy/log-file-sizes branch February 20, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith1511 smith1511 smith1511 approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

@djsly djsly Awaiting requested review from djsly djsly is a code owner

@phealy phealy Awaiting requested review from phealy phealy is a code owner

@r2k1 r2k1 Awaiting requested review from r2k1 r2k1 is a code owner

@zachary-bailey zachary-bailey Awaiting requested review from zachary-bailey zachary-bailey is a code owner

@bravebeaver bravebeaver Awaiting requested review from bravebeaver bravebeaver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timmy-wright @smith1511