feat: create a file to mark that the outbound check is skipped for network isolated cluster feature #5863
+276
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingosummer
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
timmy-wright,
zachary-bailey,
bravebeaver and
smith1511
as code owners
bingosummer
changed the title
bingosummer
force-pushed
the
binxi/ni-egress-monitor
branch
from
0fb6d15 to
40f2f54
Compare
karataliu
reviewed
Feb 24, 2025
…twork isolated cluster feature
bingosummer
force-pushed
the
binxi/ni-egress-monitor
branch
from
40f2f54 to
a74c1bc
Compare
fseldow
reviewed
Feb 24, 2025
| @@ -83,6 +83,9 @@ if [[ -n "${OUTBOUND_COMMAND}" ]]; then | |||
| eval $PROXY_VARS | |||
| fi | |||
| retrycmd_if_failure 50 1 5 $OUTBOUND_COMMAND >> /var/log/azure/cluster-provision-cse-output.log 2>&1 || exit $ERR_OUTBOUND_CONN_FAIL; | |||
| else | |||
| # This file indicates the cluster doesn't have outbound connectivity and should be excluded in future external outbound checks | |||
| touch /var/run/outbound-check-skipped | |||
There was a problem hiding this comment.
can we add something to agentbaker e2e to ensure this exists after CSE exits within NI scenarios?
cameronmeissner
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
When run
kubectl describe nodesin a network isolated cluster, we see an EgressBlocked warning. It's sent by the node-problem-detector. This PR creates a file/var/run/outbound-check-skippedto mark that the outbound check is skipped. When the file exists, the node-problem-detector will not send the EgressBlocked warning.Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: