Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scriptless e2e test for Test_Ubuntu2204_CustomCATrust #5850

Merged
merged 4 commits into from
Feb 15, 2025
Merged

add scriptless e2e test for Test_Ubuntu2204_CustomCATrust #5850

merged 4 commits into from
Feb 15, 2025

Conversation

xmzhao0822
Copy link
Contributor

What type of PR is this?

/kind test

What this PR does / why we need it:
add scriptless e2e test for Test_Ubuntu2204_CustomCATrust

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@xmzhao0822 xmzhao0822 force-pushed the xmzhao/add-e2etest-ubuntu2204-customCATrust branch from 3f57173 to d749495 Compare February 14, 2025 22:39
@xmzhao0822 xmzhao0822 marked this pull request as ready for review February 14, 2025 22:39
@xmzhao0822 xmzhao0822 enabled auto-merge (squash) February 14, 2025 22:42
@xmzhao0822 xmzhao0822 disabled auto-merge February 15, 2025 01:33
Devinwong
Devinwong approved these changes Feb 15, 2025
View reviewed changes
Copy link
Collaborator

@Devinwong Devinwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e pipeline failed with other reasons. But the new test Test_Ubuntu2204_CustomCATrust added in this PR actually passed.

@xmzhao0822 xmzhao0822 merged commit b2e4d20 into master Feb 15, 2025
15 of 16 checks passed
@xmzhao0822 xmzhao0822 deleted the xmzhao/add-e2etest-ubuntu2204-customCATrust branch February 15, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devinwong Devinwong Devinwong approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

@djsly djsly Awaiting requested review from djsly djsly is a code owner

@phealy phealy Awaiting requested review from phealy phealy is a code owner

@r2k1 r2k1 Awaiting requested review from r2k1 r2k1 is a code owner

@timmy-wright timmy-wright Awaiting requested review from timmy-wright timmy-wright is a code owner

@zachary-bailey zachary-bailey Awaiting requested review from zachary-bailey zachary-bailey is a code owner

@bravebeaver bravebeaver Awaiting requested review from bravebeaver bravebeaver is a code owner

@smith1511 smith1511 Awaiting requested review from smith1511 smith1511 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmzhao0822 @Devinwong