Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add owners for some components. Set compponents.json to no code-owner. #5837

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Add owners for some components. Set compponents.json to no code-owner. #5837

merged 4 commits into from
Feb 13, 2025

Conversation

Devinwong
Copy link
Collaborator

@Devinwong Devinwong commented Feb 13, 2025 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

  1. Add owners for some components
  2. Set components.json to no code-owner so that it can be approved and merged by component owner. Now every renovate changes to Renovate.json still needs code-owners to approve. This defeats the purpose of component owner to self-approve/merge their own PRs. If it ends up not going as expected, we can change it back.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@Devinwong Devinwong changed the title add owners for some components Add owners for some components. Set compponents.json to no code-owner. Feb 13, 2025
djsly
djsly approved these changes Feb 13, 2025
View reviewed changes
@Devinwong Devinwong merged commit f4f289e into master Feb 13, 2025
14 checks passed
@Devinwong Devinwong deleted the devinwon/add_reviewers branch February 13, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djsly djsly djsly approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

@phealy phealy Awaiting requested review from phealy phealy is a code owner

@r2k1 r2k1 Awaiting requested review from r2k1 r2k1 is a code owner

@timmy-wright timmy-wright Awaiting requested review from timmy-wright timmy-wright is a code owner

@zachary-bailey zachary-bailey Awaiting requested review from zachary-bailey zachary-bailey is a code owner

@bravebeaver bravebeaver Awaiting requested review from bravebeaver bravebeaver is a code owner

@smith1511 smith1511 Awaiting requested review from smith1511 smith1511 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Devinwong @djsly