Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove nanoserver from renovate and add a comment explaining why #5833

Merged
merged 2 commits into from
Feb 13, 2025
Merged

chore: remove nanoserver from renovate and add a comment explaining why #5833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a204c59
upgrade nanoserver to ltsc
timmy-wright Feb 13, 2025
53f594f
backout change, add comment
timmy-wright Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion parts/common/components.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
"multiArchVersionsV2": [],
"windowsVersions": [
{
"renovateTag": "registry=https://mcr.microsoft.com, name=windows/nanoserver",
"comment": "1809 gets patches every 6 months or so. The alternative is ltsc2019 which gets patches every couple of years. Most customers use 1809, so we keep that on the VHD",
"renovateTag": "<DO_NOT_UPDATE>",
"latestVersion": "1809",
"windowsSkuMatch": "2019-containerd"
},
Expand Down
1 change: 1 addition & 0 deletions schemas/components.cue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ package components
}

#WindowsVersion: {
comment?: string
k8sVersion?: string
renovateTag?: string
latestVersion: string
Expand Down
2 changes: 1 addition & 1 deletion vhdbuilder/packer/windows/components_json_helpers.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ Describe 'Tests of components.json ' {

$components.Length | Should -BeGreaterThan 0

# Pause image shouldn't change too often, so let's check that is in there.
# core images shouldn't change too often, so let's check that is in there.
$components | Should -Contain "mcr.microsoft.com/windows/servercore:ltsc2019"
$components | Should -Contain "mcr.microsoft.com/windows/nanoserver:1809"
}
Expand Down
Loading