nit: hide testvm password #5712
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason1028kr
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
djsly,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
| @@ -110,8 +111,7 @@ else | |||
| --public-ip-address "" \ | |||
| ${TARGET_COMMAND_STRING} | |||
| fi | |||
|
|
|||
| echo "VHD test VM username: $TEST_VM_ADMIN_USERNAME, password: $TEST_VM_ADMIN_PASSWORD" | |||
There was a problem hiding this comment.
I can't remember, isn't there a debug mode where we let the user keep the VM for debugging? if so then we want to upload an ssh key or something to build artifacts
though, I think at the end of the day devs can just reset the password on the VM manually
cameronmeissner
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind chore
What this PR does / why we need it:
Not sure if it's even necessary. But hide testvm password getting traced
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: