feat: support pulling images from sov cloud's MCR for network isolated cluster feature #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingosummer
requested review from
Devinwong,
lilypan26,
r2k1,
timmy-wright,
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy and
zachary-bailey
as code owners
|
lgtm pending unit tests |
bingosummer
force-pushed
the
binxi/ni-sov
branch
from
70b09fc to
78f58cf
Compare
bingosummer
force-pushed
the
binxi/ni-sov
branch
from
78f58cf to
c6b3881
Compare
fseldow
approved these changes
Feb 11, 2025
bingosummer
force-pushed
the
binxi/ni-sov
branch
from
c6b3881 to
415e333
Compare
…d cluster feature
bingosummer
force-pushed
the
binxi/ni-sov
branch
from
415e333 to
96472cc
Compare
djsly
approved these changes
Feb 13, 2025
cameronmeissner
approved these changes
Feb 13, 2025
timmy-wright
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
support pulling images from sov cloud's MCR for network isolated cluster feature
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: