fix: stop dnf from overwriting motd on azure linux nodes if motd is enabled on the node #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nabled on the node
UtheMan
requested review from
juan-lee,
cameronmeissner,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1 and
timmy-wright
as code owners
anujmaheshwari1
approved these changes
Dec 3, 2024
djsly
reviewed
Dec 4, 2024
| @@ -247,6 +247,9 @@ else | |||
| fi | |||
|
|
|||
| if [[ "${MESSAGE_OF_THE_DAY}" != "" ]]; then | |||
| if isMarinerOrAzureLinux "$OS" && [ -f /etc/dnf/automatic.conf ]; then | |||
| sed -i "s/emit_via = motd/emit_via = stdio/g" /etc/dnf/automatic.conf | |||
There was a problem hiding this comment.
where does it go when stdio is used ?
There was a problem hiding this comment.
Context: https://dnf.readthedocs.io/en/latest/automatic.html
just to standard output, i believe this particualr part of dnf is triggered by a systemd unit so that would go into journald
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.