feat: change from a bool value for bootstrapping auth method to an enum. #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmy-wright
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy and
r2k1
as code owners
timmy-wright
changed the title
r2k1
reviewed
Nov 4, 2024
djsly
reviewed
Nov 4, 2024
timmy-wright
force-pushed
the
timmy/enum_for_auth_methods
branch
from
2594ee2 to
44ac254
Compare
r2k1
reviewed
Nov 4, 2024
r2k1
reviewed
Nov 4, 2024
r2k1
approved these changes
Nov 4, 2024
timmy-wright
force-pushed
the
timmy/enum_for_auth_methods
branch
from
531cad5 to
bfbf0c2
Compare
timmy-wright
force-pushed
the
timmy/enum_for_auth_methods
branch
from
bfbf0c2 to
a29e1c4
Compare
timmy-wright
force-pushed
the
timmy/enum_for_auth_methods
branch
from
a29e1c4 to
9887504
Compare
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Changes from a bool for auth bootstrapping method to an enum, which is more extensible in future, and is needed by stretch.
Requirements:
Special notes for your reviewer:
Release note: