Reduce number of e2e tests to reduce VM usage #5107
Conversation
r2k1
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy and
timmy-wright
as code owners
e2e/scenario_test.go
Outdated
| @@ -1201,39 +1126,3 @@ func Test_ubuntu1804imdsrestriction_mangletable(t *testing.T) { | |||
| }, | |||
| }) | |||
| } | |||
|
|
|||
| func Test_Ubuntu2204MessageOfTheDay(t *testing.T) { | |||
There was a problem hiding this comment.
will wanna check with @UtheMan on these, I believe they were recently added
There was a problem hiding this comment.
That should be fine, added it as separate test since its a separate feature, but if we are fine with combining these cases like this then i'm all for it.
There was a problem hiding this comment.
We should have a Happy Path test where nothing gets configured and we ensure that none of those settings are getting set.
We could look at combining multiple features into another single e2e test to minimize the number of tests
There was a problem hiding this comment.
While it looks like we didn't set nothing, it's far from truth:
https://github.com/Azure/AgentBaker/blob/master/e2e/template.go#L13-L449
|
might also consider just adding a new tag to indicate that a given scenario shouldn't be executed by default? granted scenarios with said tag would probably just end up rotting anyways |
e2e/scenario_test.go
Outdated
| @@ -212,33 +214,6 @@ func Test_azurelinuxv2gpu(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func Test_azurelinuxv2gpu_azurecni(t *testing.T) { | |||
There was a problem hiding this comment.
@ganeshkumarashok do you recall why we had separate tests for azure cni?
We could use some sort of "suggestions" for when to run certain scenarios like there are in RP, but many of the tests are tied to CSE execution which could get borked for other things for no reason sometimes... so not sure how safe that would be. |
e2e/scenario_test.go
Outdated
| }, | ||
| LiveVMValidators: []*LiveVMValidator{ | ||
| // for now azure linux reports itself as mariner, so expected version for azure linux is the same as that for mariner | ||
| mobyComponentVersionValidator("containerd", getExpectedPackageVersions("containerd", "mariner", "current")[0], "dnf"), | ||
| FileHasContentsValidator("/etc/motd", "foobar"), |
There was a problem hiding this comment.
personally I dont like to test non default settings in the base happy path. We should actually ensure that ALL settings that are not configured are not showing up in the base happy path test.
e2e/scenario_test.go
Outdated
| }, | ||
| }) | ||
| } | ||
|
|
||
| func Test_marinerv2gpu_azurecni(t *testing.T) { |
There was a problem hiding this comment.
maybe we should keep azure_cni + gpu on the latest AzureLinux ? marinerv2 is somewhat deprecated now no ?
e2e/scenario_test.go
Outdated
| @@ -600,33 +549,6 @@ func Test_ubuntu1804gpu(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func Test_ubuntu1804gpu_azurecni(t *testing.T) { | |||
There was a problem hiding this comment.
are we loosing the only 1804gpu test we had ?
r2k1
requested review from
zachary-bailey,
bravebeaver and
smith1511
as code owners
/kind test
This should reduce pressure on VM quota and save some $$$.
Merge "message of the day" test with other tests.
I also don't think we need to test all permutations of OS and Network for gpu tests. GPU and K8s Network should be unrelated.