Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump windows image version for 2024-06B #4505

Merged
merged 4 commits into from
Jun 12, 2024
Merged

feat: bump windows image version for 2024-06B #4505

merged 4 commits into from
Jun 12, 2024

Conversation

junjiezhang1997
Copy link
Collaborator

@junjiezhang1997 junjiezhang1997 commented Jun 12, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update Windows base images to 2024-06B

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9476392823

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.969%
Totals Coverage Status
Change from base Build 9476323211: 0.0%
Covered Lines: 2627
Relevant Lines: 3458
💛 - Coveralls

@junjiezhang1997 junjiezhang1997 added the VHD your change will be included in the following VHDs label Jun 12, 2024
@junjiezhang1997 junjiezhang1997 force-pushed the junjiezhang1997/win-2024-06b branch from 1e6bc21 to 305c079 Compare June 12, 2024 06:13
@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9477627773

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.969%
Totals Coverage Status
Change from base Build 9476323211: 0.0%
Covered Lines: 2627
Relevant Lines: 3458
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9477645322

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.969%
Totals Coverage Status
Change from base Build 9477179821: 0.0%
Covered Lines: 2627
Relevant Lines: 3458
💛 - Coveralls

@junjiezhang1997 junjiezhang1997 force-pushed the junjiezhang1997/win-2024-06b branch from 305c079 to f2b0603 Compare June 12, 2024 07:16
@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9478352583

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.969%
Totals Coverage Status
Change from base Build 9477179821: 0.0%
Covered Lines: 2627
Relevant Lines: 3458
💛 - Coveralls

AbelHu
AbelHu approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@junjiezhang1997 junjiezhang1997 enabled auto-merge (squash) June 12, 2024 08:13
@junjiezhang1997 junjiezhang1997 merged commit 7de70cc into master Jun 12, 2024
23 checks passed
@junjiezhang1997 junjiezhang1997 deleted the junjiezhang1997/win-2024-06b branch June 12, 2024 08:41
junjiezhang1997 added a commit that referenced this pull request Jun 12, 2024
@junjiezhang1997
feat: bump windows image version for 2024-06B (#4505)
4f88809
@junjiezhang1997 junjiezhang1997 mentioned this pull request Jun 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbelHu AbelHu AbelHu approved these changes

@ShiqianTao ShiqianTao ShiqianTao approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

@djsly djsly Awaiting requested review from djsly djsly is a code owner

Assignees
No one assigned
Labels
VHD your change will be included in the following VHDs windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@junjiezhang1997 @coveralls @AbelHu @ShiqianTao