Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing templates_generated.go #4434

Merged
merged 3 commits into from
May 24, 2024

Conversation

artunduman
Copy link
Collaborator

@artunduman artunduman commented May 23, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
It looks like templates_generated.go was removed by this PR on April 25.

However, it was generated again and was added back a few days later, probably because of the use of an old Makefile.
image

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented May 23, 2024

Pull Request Test Coverage Report for Build 9227427650

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.969%

Totals Coverage Status
Change from base Build 9226661580: 0.0%
Covered Lines: 2627
Relevant Lines: 3458

💛 - Coveralls

@artunduman artunduman mentioned this pull request May 23, 2024
4 tasks
@artunduman artunduman enabled auto-merge (squash) May 24, 2024 01:04
@cameronmeissner
Copy link
Collaborator

thanks for taking care of this! I had this on my backlog for past week lol

@cameronmeissner
Copy link
Collaborator

will run abe2e's to make sure everything's still working, which I'm sure it is

Copy link
Contributor

@djsly djsly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it be added ti the .gitignore file such that it doesnt happen again ?

@cameronmeissner
Copy link
Collaborator

can it be added ti the .gitignore file such that it doesnt happen again ?

good suggestion, added.

we might also think about adding a GH to make sure out-dated branches aren't adding it back as well

@cameronmeissner cameronmeissner disabled auto-merge May 24, 2024 16:42
@cameronmeissner cameronmeissner merged commit a229ee1 into master May 24, 2024
16 checks passed
@cameronmeissner cameronmeissner deleted the artunduman/remove-templates-generated branch May 24, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants