-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removing templates_generated.go #4434
chore: removing templates_generated.go #4434
Conversation
Pull Request Test Coverage Report for Build 9227427650Details
💛 - Coveralls |
thanks for taking care of this! I had this on my backlog for past week lol |
will run abe2e's to make sure everything's still working, which I'm sure it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it be added ti the .gitignore file such that it doesnt happen again ?
good suggestion, added. we might also think about adding a GH to make sure out-dated branches aren't adding it back as well |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
It looks like
templates_generated.go
was removed by this PR on April 25.However, it was generated again and was added back a few days later, probably because of the use of an old Makefile.

Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: