Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self-contained: add go binary to vhd #4396

Merged
merged 20 commits into from
May 23, 2024
Merged

self-contained: add go binary to vhd #4396

merged 20 commits into from
May 23, 2024

Conversation

lilypan26
Copy link
Contributor

@lilypan26 lilypan26 commented May 13, 2024 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:
Add go binary generation to VHD build

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented May 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9212719295

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 75.969%
Totals Coverage Status
Change from base Build 9211682853: -0.9%
Covered Lines: 2627
Relevant Lines: 3458
💛 - Coveralls

@djsly
Copy link
Contributor

djsly commented May 23, 2024

what does NBC stand for ?

@lilypan26
Copy link
Contributor Author

what does NBC stand for ?

node bootstrapping config/contract

@lilypan26 lilypan26 merged commit ed04d8a into master May 23, 2024
26 checks passed
@lilypan26 lilypan26 deleted the lily/add-go-binary branch May 23, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djsly djsly djsly left review comments

@cameronmeissner cameronmeissner cameronmeissner approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lilypan26 @coveralls @djsly @cameronmeissner @anujmaheshwari1