-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updating cached dropgz to v0.1.3 #4329
Conversation
Pull Request Test Coverage Report for Build 8837797766Details
💛 - Coveralls |
], | ||
"prefetchOptimizations": [ | ||
{ | ||
"version": "v0.0.15", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably want to keep prefetching 0.0.15 if RP hasn't switched over to using 0.1.3 everywhere as of yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this merges in we want to change RP to 0.1.3. But if we need to have it in RP first I can make them separate PRs.
Our current workstream for upgrading our images is AgentBaker before RP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's fine, let's keep prefetching 0.0.15 until the corresponding RP change has rolled out to all prod regions then
d692c3b
to
d991a98
Compare
@@ -67,7 +67,7 @@ | |||
"multiArchVersions": [ | |||
"v0.0.4.1", | |||
"v0.0.15", | |||
"v0.1.1" | |||
"v0.1.3" | |||
], | |||
"prefetchOptimizations": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also prefetch 0.1.3 so we can start seeing benefit as soon as possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though it isn't in RP yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it back to prefetch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that's fine, but we should be prefetching both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just added it so it is both are being prefetched.
d62d25a
to
7addb85
Compare
What type of PR is this?
kind feature
What this PR does / why we need it:
chore: updating cached dropgz to v0.1.3
dropgz v0.1.3 has fixes for Windows Dualstack Overlay
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: