Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating cached dropgz to v0.1.3 #4329

Merged
merged 6 commits into from
Apr 25, 2024
Merged

chore: updating cached dropgz to v0.1.3 #4329

merged 6 commits into from
Apr 25, 2024

Conversation

rjdenney
Copy link
Contributor

What type of PR is this?
kind feature

What this PR does / why we need it:
chore: updating cached dropgz to v0.1.3
dropgz v0.1.3 has fixes for Windows Dualstack Overlay
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8837797766

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.071%

Totals Coverage Status
Change from base Build 8837346285: 0.0%
Covered Lines: 2467
Relevant Lines: 3120

💛 - Coveralls

],
"prefetchOptimizations": [
{
"version": "v0.0.15",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably want to keep prefetching 0.0.15 if RP hasn't switched over to using 0.1.3 everywhere as of yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this merges in we want to change RP to 0.1.3. But if we need to have it in RP first I can make them separate PRs.

Our current workstream for upgrading our images is AgentBaker before RP

Copy link
Collaborator

@cameronmeissner cameronmeissner Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fine, let's keep prefetching 0.0.15 until the corresponding RP change has rolled out to all prod regions then

@@ -67,7 +67,7 @@
"multiArchVersions": [
"v0.0.4.1",
"v0.0.15",
"v0.1.1"
"v0.1.3"
],
"prefetchOptimizations": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also prefetch 0.1.3 so we can start seeing benefit as soon as possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it isn't in RP yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it back to prefetch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that's fine, but we should be prefetching both

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added it so it is both are being prefetched.

@rjdenney rjdenney enabled auto-merge (squash) April 25, 2024 18:45
@rjdenney rjdenney merged commit 6de1699 into master Apr 25, 2024
26 checks passed
@rjdenney rjdenney deleted the updatedropgzv0.1.3 branch April 25, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants