feat: add parameters for collect-windows-logs.ps1 #4325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiqianTao
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997 and
jason1028kr
as code owners
Pull Request Test Coverage Report for Build 8793716454Details
💛 - Coveralls |
ShiqianTao
force-pushed
the
shtao/du-parameter
branch
from
bfe4f10 to
558221b
Compare
ShiqianTao
added
windows cse package
ShiqianTao
force-pushed
the
shtao/du-parameter
branch
from
558221b to
6fa479e
Compare
AbelHu
reviewed
Apr 21, 2024
| C:\aks-tools\DU\du.exe /accepteula | ||
| C:\aks-tools\DU\du.exe -l 1 C:\ProgramData\containerd\root\io.containerd.snapshotter.v1.windows\snapshots\ > "$ENV:TEMP\$timeStamp-du-snapshot-folder-size.txt" | ||
| $paths += "$ENV:TEMP\$timeStamp-du-snapshot-folder-size.txt" | ||
| if ($args.Count -gt 0 -and $args -contains "disk-usage") { |
There was a problem hiding this comment.
We have a command to collect disk-usage so the name may be confused. How about containers-disk-usage or snapshots-size? Could we not use contain since a valid name with different suffix can also pass the validation
There was a problem hiding this comment.
updated code to switch param
ShiqianTao
force-pushed
the
shtao/du-parameter
branch
from
6fa479e to
39fd0d6
Compare
ShiqianTao
force-pushed
the
shtao/du-parameter
branch
from
39fd0d6 to
6d14566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: