Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cache azure cns v1.5.24 in windows vhd #4230

Merged
merged 1 commit into from
Apr 1, 2024
Merged

chore: cache azure cns v1.5.24 in windows vhd #4230

merged 1 commit into from
Apr 1, 2024

Conversation

junjiezhang1997
Copy link
Collaborator

What type of PR is this?
/kind feature

What this PR does / why we need it:
cache azure cns v1.5.24 in windows vhd.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@junjiezhang1997 junjiezhang1997 added windows VHD your change will be included in the following VHDs labels Apr 1, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8503137722

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.246%
Totals Coverage Status
Change from base Build 8502871981: 0.0%
Covered Lines: 2348
Relevant Lines: 2926
💛 - Coveralls

AbelHu
AbelHu approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@junjiezhang1997 junjiezhang1997 merged commit 887ce0e into master Apr 1, 2024
21 checks passed
@junjiezhang1997 junjiezhang1997 deleted the junjiezhang/cache-cns-v1.5.24-in-windows-vhd branch April 1, 2024 04:44
@junjiezhang1997 junjiezhang1997 mentioned this pull request Apr 1, 2024
Closed
4 tasks
@rbtr
Copy link
Contributor

rbtr commented Apr 10, 2024 •
edited
Loading

hey @junjiezhang1997 thanks for updating this for @rjdenny - we do try to keep the Linux and Windows versions in sync though
ex https://github.com/Azure/AgentBaker/pull/4276/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbelHu AbelHu AbelHu approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

Assignees
No one assigned
Labels
VHD your change will be included in the following VHDs windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@junjiezhang1997 @coveralls @rbtr @AbelHu