Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizing NB contract including CustomLinuxOSConfig and others #4217

Merged
merged 20 commits into from
Mar 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
208 changes: 64 additions & 144 deletions pkg/proto/nbcontract/v1/config.pb.go

Large diffs are not rendered by default.

30 changes: 16 additions & 14 deletions pkg/proto/nbcontract/v1/config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -83,25 +83,27 @@ message Configuration {
// ensure_no_dupe_promiscuous_bridge specifies whether to ensure no duplicate promiscuous bridge
bool ensure_no_dupe_promiscuous_bridge = 45;

// custom_search_domain specifies the custom search domain configuration
// custom_search_domain specifies the custom search domain configurations
CustomSearchDomain custom_search_domain = 46;
optional CustomLinuxOSConfig custom_linux_os_config = 47;

//we do not need these in the final contract, these are consts
string cse_helper_filepath = 49;
string cse_distro_helper_filepath = 50;
string cse_install_filepath = 51;
string cse_distro_install_filepath = 52;
string cse_config_filepath = 53;

string dhcpv6_service_filepath = 54;
string dhcpv6_config_filepath = 55;
// custom_linux_os_config specifies the custom Linux OS configurations including SwapFile, SysCtl configs, etc.
CustomLinuxOSConfig custom_linux_os_config = 47;

// azure_private_registry_server specifies the Azure private registry server
string azure_private_registry_server = 56;

// private_egress_proxy_address specifies the private egress proxy address
string private_egress_proxy_address = 57;
FeatureState artifact_streaming_enabled = 58;
bool is_kata = 59; // we can calculate this on the VHD, will remove from final contract
bool needs_cgroupv2 = 60; // we can calculate this on the VHD, will remove from final contract

// enable_artifact_streaming specifies whether artifact streaming is enabled or disabled on the VM node
bool enable_artifact_streaming = 58;

// is_kata specifies whether the node is a Kata node
bool is_kata = 59;

// needs_cgroupv2 specifies whether the node needs cgroupv2
// when we actually work on the go binary, we should be able to query from the system. By then we can remove this.
bool needs_cgroupv2 = 60;

// Here begins the final contract
optional HTTPProxyConfig http_proxy_config = 61;
Expand Down
Loading
Loading