Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: toggles in agentbakersvc #4206

Merged
merged 11 commits into from
Apr 5, 2024
Merged

feat: toggles in agentbakersvc #4206

merged 11 commits into from
Apr 5, 2024

Conversation

cameronmeissner
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Mar 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8574925638

Details

  • 67 of 67 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.8%) to 82.077%
Files with Coverage Reduction New Missed Lines %
pkg/agent/datamodel/sig_config.go 2 92.19%
Totals Coverage Status
Change from base Build 8547799253: 1.8%
Covered Lines: 2450
Relevant Lines: 2985
💛 - Coveralls

@cameronmeissner cameronmeissner marked this pull request as draft March 28, 2024 19:41
@cameronmeissner cameronmeissner marked this pull request as ready for review April 1, 2024 20:09
@cameronmeissner cameronmeissner merged commit d70ff99 into master Apr 5, 2024
17 checks passed
@cameronmeissner cameronmeissner deleted the cameissner/absvc-toggles branch April 5, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bravebeaver bravebeaver bravebeaver left review comments

@Devinwong Devinwong Devinwong approved these changes

@anujmaheshwari1 anujmaheshwari1 anujmaheshwari1 approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cameronmeissner @coveralls @Devinwong @anujmaheshwari1 @bravebeaver