feat: add node graceful shutdown kubelet config #4149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weichch
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu and
junjiezhang1997
as code owners
Co-authored-by: Wei Chen<[email protected]>
Co-authored-by: Wei Chen<[email protected]>
Co-authored-by: Wei Chen<[email protected]>
weichch
force-pushed
the
weichen/graceful-node-shutdown
branch
from
5023413 to
2864425
Compare
Pull Request Test Coverage Report for Build 8318498735Details
💛 - Coveralls |
|
As per mentioned in #4147, the feature gate is by default enabled in all k8s versions we currently support. |
cameronmeissner
approved these changes
Mar 11, 2024
cameronmeissner
approved these changes
Mar 12, 2024
UtheMan
reviewed
Mar 12, 2024
| // Default: "0s" | ||
| // +featureGate=GracefulNodeShutdown | ||
| // +optional | ||
| ShutdownGracePeriodCriticalPods Duration `json:"shutdownGracePeriodCriticalPods,omitempty"` |
There was a problem hiding this comment.
Where do we validate whether ShutdownGracePeriodCriticalPods is lower than ShutdownGracePeriod?
There was a problem hiding this comment.
Validation is going to be in RP, similar to ImageGcHighThreshold and ImageGcLowThreshold.
weichch
commented
Mar 18, 2024
| @@ -497,6 +497,12 @@ func setCustomKubeletConfig(customKc *datamodel.CustomKubeletConfig, | |||
| if customKc.PodMaxPids != nil { | |||
| kubeletConfig.PodPidsLimit = to.Int64Ptr(int64(*customKc.PodMaxPids)) | |||
| } | |||
| if customKc.ShutdownGracePeriod != nil { | |||
There was a problem hiding this comment.
I also wanted to add some defaulting logic based on Kubernetes version. What do you think if we add IsKubernetesVersionGe(xxx) in this method? @UtheMan
|
I'm putting this on hold now as there might be some investigations I need to do before this can be merged. |
|
@weichch closing for now due to inactivity, feel free to reopen when needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
This PR adds node graceful shutdown Kubelet config items and exposes those for client use, so that we can allow customers to enable this feature on their nodes.
This PR is recreated from the previous PR (#4147) from fork as per comment.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: