test: add benchmarks and helper functions #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachary-bailey
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu and
junjiezhang1997
as code owners
Pull Request Test Coverage Report for Build 8270408024Details
💛 - Coveralls |
| @@ -242,8 +265,8 @@ cat << EOF >> ${VHD_LOGS_FILEPATH} | |||
| EOF | |||
|
|
|||
| echo "${CONTAINER_RUNTIME} images pre-pulled:" >> ${VHD_LOGS_FILEPATH} | |||
|
|
|||
|
|
|||
| stop_watch $capture_time "Pull NVIDIA Image, Start installBcc subshell" false | |||
There was a problem hiding this comment.
nit: "Pull NVIDIA driver image (mcr)" - minor change to note this is the image from MCR/hosted by Azure. There's a separate Nvidia driver container which will be used in the future.
|
Thanks for addressing the comments here: #4067. |
ganeshkumarashok
approved these changes
Mar 11, 2024
zachary-bailey
force-pushed
the
zacharybailey/v3AddBenchmarksAndHelperFunctions
branch
from
f3041e4 to
95d0d5e
Compare
zachary-bailey
force-pushed
the
zacharybailey/v3AddBenchmarksAndHelperFunctions
branch
from
95d0d5e to
77f1052
Compare
zachary-bailey
force-pushed
the
zacharybailey/v3AddBenchmarksAndHelperFunctions
branch
from
ad74ed5 to
1606dce
Compare
ganeshkumarashok
deleted the
zacharybailey/v3AddBenchmarksAndHelperFunctions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
What this PR does / why we need it:
This PR adds benchmarking helper functions to cse_helpers.sh and then utilizes them in pre / post / install-dependencies scripts. These can be used to view benchmarking data while running ADO pipelines, and can be reviewed during the build or after.
This data will later be used to programmatically evaluate the effect of a PRs code changes on the VHD Build Time.
Which issue(s) this PR fixes:
This code prevents the developer from not being able to easily evaluate how long certain parts of the VHD Build process take.