-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update npm linux to v1.5.23 and windows to v1.5.5 #4124
Conversation
Pull Request Test Coverage Report for Build 8288951893Details
💛 - Coveralls |
@@ -67,7 +67,7 @@ | |||
"downloadURL": "mcr.microsoft.com/containernetworking/azure-npm:*", | |||
"amd64OnlyVersions": [], | |||
"multiArchVersions": [ | |||
"v1.4.45.3" | |||
"v1.5.23" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we usually keep the older version
and any updates on windows side here?
"mcr.microsoft.com/containernetworking/azure-npm:v1.4.34" |
"mcr.microsoft.com/containernetworking/azure-npm:v1.4.34" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the windows versions to align with the versions in RP. I will merge this PR once i confirm theres no need to rollback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to create a PR from a branch in Azure/AgentBaker instead of the branch in your forked repo to run all tests.
|
What type of PR is this? NPM Version Update
What this PR does / why we need it: Updates the NPM Linux image version from v1.4.45.3 to v1.5.23 to address Ubuntu repo updates/CVEs, remove building and publishing NPM images with certs/private keys, and aligns NPM's minor version with CNS/CNI versions. Updates NPM Windows image version from v1.4.34 to v1.5.5 to align with image in RP.
Release note: https://github.com/Azure/azure-container-networking/releases/tag/v1.5.23