Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate the free space in AKS Windows VHDs #4117

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

AbelHu
Copy link
Member

@AbelHu AbelHu commented Feb 27, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Validate the free space in AKS Windows VHDs. Based on below logs in building AKS Windows VHDs in the past months, we set $global:lowestFreeSpace to 2GB. It can avoid that the node provisioning fails because the disk is full before resize-osdisk is called in AKS Windows CSE script.

2023-10B: azure-arm: 2023-10-11T02:05:47.3821397+00:00: Disk C: Free space: 2870341632, Total size: 37054574592
2023-11B: azure-arm: 2023-11-15T04:24:35.6762674+00:00: Disk C: Free space: 7530057728, Total size: 37054574592
2023-12B: azure-arm: 2023-12-13T07:15:49.5874780+00:00: Disk C: Free space: 4424978432, Total size: 37054574592
2024-01B: azure-arm: 2024-01-10T06:19:45.8406506+00:00: Disk C: Free space: 4901367808, Total size: 37054574592
2024-01B: azure-arm: 2024-02-02T03:28:36.7695401+00:00: Disk C: Free space: 2284965888, Total size: 37054574592

Test logs in https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=88314843&view=logs&j=da83e503-f0a7-5e39-4c4e-547ddc065d07&t=c25eccdb-c467-51a1-7682-f93363e2409c:

    azure-arm: 2024-02-27T08:28:37.9559130+00:00: Get Disk info
    azure-arm: 2024-02-27T08:28:38.5497165+00:00: Disk C: Free space: 2969219072, Total size: 37054574592
    azure-arm: Disk C: Free space is less than 3221225472
    azure-arm: At C:\Windows\Temp\script-65dd8fe0-a38c-bcf7-1892-c8d74ee7a310.ps1:748 char:17
    azure-arm: + ...             throw "Disk C: Free space is less than $($global:lowestFr ...
    azure-arm: +                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    azure-arm:     + CategoryInfo          : OperationStopped: (Disk C: Free sp...than 3221225472:String) [], RuntimeException
    azure-arm:     + FullyQualifiedErrorId : Disk C: Free space is less than 3221225472
    azure-arm:
==> azure-arm: Provisioning step had errors: Running the cleanup provisioner, if present...

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 8061916206

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.39%

Totals Coverage Status
Change from base Build 8061846000: 0.0%
Covered Lines: 2292
Relevant Lines: 2887

💛 - Coveralls

@AbelHu AbelHu merged commit 938a298 into master Feb 27, 2024
20 checks passed
@AbelHu AbelHu deleted the abelch/validate-win-free-space branch February 27, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VHD your change will be included in the following VHDs windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants